-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GHA conda setup performance #2701
Conversation
Codecov ReportBase: 87.06% // Head: 87.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.02%
==========================================
Files 757 757
Lines 84596 84596
==========================================
- Hits 73652 73639 -13
- Misses 10944 10957 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TIL about mamba. Thanks for teaching me something! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a grammar snark, but besides that, it's good.
Fixes # .
Summary/Motivation:
This PR reworks how the GHA jobs configure conda environments, with an eye to reducing the overall GHA test time. This makes two significant changes:
conda install
command. This prevents unnecessary rework (e.g., installing a package and then later upgrading it from a different channel)mamba
to solve the environment, if possible. This improved solver can be significantly more efficient than the default conda solver.Preliminary testing shaves ~20 minutes off the
win/3.9
job and more than an hour off the problematic win/3.11 job.Changes proposed in this PR:
mamba
to solve the environment, if possibleLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: