Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing version argument to relocated_module warning in incidence_analysis #2745

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

blnicho
Copy link
Member

@blnicho blnicho commented Feb 16, 2023

Summary/Motivation:

#2727 and #2744 were merged without syncing the main branch in between which caused tests to start failing. This adds the missing version argument in incidence_analysis. The version number will be updated as part of the release process.

Changes proposed in this PR:

  • Add missing version argument in incidence_analysis.util

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 25.44% // Head: 86.72% // Increases project coverage by +61.27% 🎉

Coverage data is based on head (5500514) compared to base (ecd98ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2745       +/-   ##
===========================================
+ Coverage   25.44%   86.72%   +61.27%     
===========================================
  Files         642      775      +133     
  Lines       83750    87042     +3292     
===========================================
+ Hits        21312    75484    +54172     
+ Misses      62438    11558    -50880     
Flag Coverage Δ
linux 83.79% <100.00%> (?)
osx 73.27% <100.00%> (?)
other 83.97% <100.00%> (?)
win 81.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/incidence_analysis/util.py 100.00% <100.00%> (ø)
examples/pyomobook/abstract-ch/param2a.py 100.00% <0.00%> (ø)
examples/pyomobook/blocks-ch/blocks_lotsizing.py 100.00% <0.00%> (ø)
...amples/gdp/constrained_layout/cons_layout_model.py 100.00% <0.00%> (ø)
examples/pyomobook/abstract-ch/param7b.py 100.00% <0.00%> (ø)
examples/pyomobook/abstract-ch/set1.py 100.00% <0.00%> (ø)
examples/pyomobook/scripts-ch/value_expression.py 100.00% <0.00%> (ø)
examples/pyomo/core/t5.py 100.00% <0.00%> (ø)
examples/pyomobook/abstract-ch/param3.py 100.00% <0.00%> (ø)
examples/kernel/constraints.py 100.00% <0.00%> (ø)
... and 603 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrmundt mrmundt merged commit f115069 into Pyomo:main Feb 16, 2023
@blnicho blnicho deleted the fix-deprecation-version branch February 16, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants