Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appsi logging #2787

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Appsi logging #2787

merged 2 commits into from
Mar 25, 2023

Conversation

michaelbynum
Copy link
Contributor

Changes proposed in this PR:

  • Use capture_output and TeeStream to make solver output control consistent across subprocess-based and python-based solver interfaces in appsi. In particular, this makes the Gurobi and Highs interfaces work better with logging.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 92.45% and project coverage change: -0.02 ⚠️

Comparison is base (f74ee5e) 87.02% compared to head (6837860) 87.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
- Coverage   87.02%   87.01%   -0.02%     
==========================================
  Files         763      763              
  Lines       87123    87143      +20     
==========================================
+ Hits        75819    75824       +5     
- Misses      11304    11319      +15     
Flag Coverage Δ
linux 84.02% <92.45%> (+<0.01%) ⬆️
osx 73.51% <66.03%> (+<0.01%) ⬆️
other 84.20% <92.45%> (+<0.01%) ⬆️
win 81.53% <90.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/appsi/solvers/highs.py 92.21% <88.88%> (+0.17%) ⬆️
pyomo/contrib/appsi/solvers/gurobi.py 84.72% <96.15%> (+0.15%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michaelbynum michaelbynum merged commit 1a5fbfd into Pyomo:main Mar 25, 2023
@michaelbynum michaelbynum deleted the appsi_logging branch February 25, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants