Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic constant for visitor tests for python 3.11.2 #2799

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Apr 9, 2023

Fixes # .

Summary/Motivation:

Python 3.11.2 appears to need a larger "magic constant" to trigger the "unexpected" RecursionError warning.

Changes proposed in this PR:

  • increase the magic constant to trigger the unexpected RecursionError from 3 to 5 (resolves test failures on python 3.11.2)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested review from blnicho and mrmundt April 9, 2023 04:45
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (63a3c60) 87.00% compared to head (b3e0a9d) 87.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2799   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         763      763           
  Lines       87213    87213           
=======================================
+ Hits        75881    75882    +1     
+ Misses      11332    11331    -1     
Flag Coverage Δ
linux 84.02% <ø> (+<0.01%) ⬆️
osx 73.52% <ø> (ø)
other 84.20% <ø> (ø)
win 81.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrmundt mrmundt merged commit f723680 into Pyomo:main Apr 10, 2023
@jsiirola jsiirola deleted the fix-visitor-tests-3.11 branch April 12, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants