Improve robustness of calculate_variable_from_constraint()
#2812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
#2806 accidentally changed the exception type expected when converting an expression to sympy fails (from
TypeError
toValueError
). This changes the exception back toTypeError
.In addition, this adds behavior to
calculate_variable_from_constraint()
so that if the user does not specify a specific differentiation method and symbolic differentiation with sympy fails, then it will (nearly silently) fall back on numeric differentiation. This resolves user experience issues encountered with tools that wrapcalculate_variable_from_constraint()
likesolve_strongly_connected_components()
(see, e.g., https://github.com/IDAES/idaes-pse/pull/1170/files#r1170267327).Changes proposed in this PR:
calculate_variable_from_constraint()
: implicitly fall back on numeric differentiation when symbolic differentiation fails and no differentiation mode was explicitly setLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: