Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: lint test is a prereq only for PR/main builds #2818

Merged
merged 2 commits into from
May 1, 2023

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

The linter test should only be a prerequisite for PRs and the main branch. User branch builds should proceed even if the linter fails: this should significantly reduce the number of NFC: apply black commits during development.

Changes proposed in this PR:

  • Only preemptively fail PR/main builds based on a failed linter job

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested a review from mrmundt April 28, 2023 20:24
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (5417276) 86.96% compared to head (8d4e328) 87.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2818      +/-   ##
==========================================
+ Coverage   86.96%   87.17%   +0.20%     
==========================================
  Files         764      764              
  Lines       88262    88262              
==========================================
+ Hits        76761    76940     +179     
+ Misses      11501    11322     -179     
Flag Coverage Δ
linux 84.22% <ø> (+<0.01%) ⬆️
osx 73.86% <ø> (+<0.01%) ⬆️
other 84.40% <ø> (+0.19%) ⬆️
win 81.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michaelbynum michaelbynum merged commit 21821ac into Pyomo:main May 1, 2023
@jsiirola jsiirola deleted the gha-lint-branch branch August 28, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants