Add support for infix Boolean logical operators #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
- Coverage 87.19% 87.19% -0.01%
==========================================
Files 765 765
Lines 88471 88504 +33
==========================================
+ Hits 77146 77171 +25
- Misses 11325 11333 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
NFC: Fixing typo
blnicho
approved these changes
May 21, 2023
emma58
approved these changes
May 22, 2023
| We omit support for most infix operators, e.g. :code:`Y[1] >> Y[2]`, due to concerns about non-intuitive Python operator precedence. | ||
| We omit support for some infix operators, e.g. :code:`Y[1] >> Y[2]`, due to concerns about non-intuitive Python operator precedence. |
There was a problem hiding this comment.
Actually... Do we need this line of documentation at all? Isn't it just telling mice about cookies we're never planning on baking anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
The initial implementation of the logical expression system intentionally omitted most infix "Boolean" operators because the "attractive" operators in Python had precedence that differs from their use in logical expressions. In particular, using the shift operator (
>>) for implication caused problems. However, using bitwise operators (&,|, and^) for BooleanVar / logical expressions does not have that problem.This PR adds infix implementations for AND, OR, and XOR operations on BooleanValue objects (and thus all logical expressions)
This PR does NOT implement
__eq__, or__ne__(although a later PR probably should ... and will be needed for #2541)Changes proposed in this PR:
__and__,__or__, and__xor__(along with their reversed and inplace versions) for BooleanValue objectsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: