Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up implicit function imports #2892

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

Robbybp
Copy link
Contributor

@Robbybp Robbybp commented Jun 30, 2023

Summary/Motivation:

I noticed several unused imports in pyomo.contrib.pynumero.algorithms.solvers.implicit_functions, and one import that was causing a deprecation warning.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (67e900c) 87.46% compared to head (688668b) 87.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   87.46%   87.45%   -0.01%     
==========================================
  Files         771      771              
  Lines       89651    89646       -5     
==========================================
- Hits        78410    78398      -12     
- Misses      11241    11248       +7     
Flag Coverage Δ
linux 84.52% <100.00%> (-0.01%) ⬇️
osx 74.57% <100.00%> (-0.02%) ⬇️
other 84.69% <100.00%> (-0.01%) ⬇️
win 82.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../pynumero/algorithms/solvers/implicit_functions.py 96.47% <100.00%> (-0.08%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blnicho blnicho merged commit bd52500 into Pyomo:main Jun 30, 2023
@Robbybp Robbybp deleted the implicit-function-imports branch June 30, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants