-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAMS: fix pickling models, update tests #2913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good minus one question
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 770 770
Lines 89632 89637 +5
=======================================
+ Hits 78721 78726 +5
Misses 10911 10911
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Fixes # .
Summary/Motivation:
This resolves some long-standing issues in the GAMS interface that were not (until recently) being caught by the test harness
Changes proposed in this PR:
GAMSSymbolMap
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: