Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAMS: fix pickling models, update tests #2913

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

This resolves some long-standing issues in the GAMS interface that were not (until recently) being caught by the test harness

Changes proposed in this PR:

  • Implement custom picklable GAMSSymbolMap
  • Update list of expected GAMS test failures

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus one question

pyomo/repn/plugins/gams_writer.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (be93e57) 87.82% compared to head (777d242) 87.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2913   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         770      770           
  Lines       89632    89637    +5     
=======================================
+ Hits        78721    78726    +5     
  Misses      10911    10911           
Flag Coverage Δ
linux 84.89% <87.50%> (+0.03%) ⬆️
osx 74.63% <87.50%> (+0.04%) ⬆️
other 85.07% <87.50%> (+0.03%) ⬆️
win 82.14% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/repn/plugins/gams_writer.py 93.21% <87.50%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrmundt mrmundt merged commit 4f2d5fc into Pyomo:main Jul 19, 2023
29 of 30 checks passed
@jsiirola jsiirola deleted the gams-pickle branch July 19, 2023 20:31
jsiirola added a commit to jsiirola/pyomo that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants