Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo in gdp.hull transformation #2915

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

emma58
Copy link
Contributor

@emma58 emma58 commented Jul 19, 2023

Fixes # .

Summary/Motivation:

This fixes a sneaky typo in gdp.hull having to do with making disaggregated variables local in nested GDPs.

Changes proposed in this PR:

  • Fixes a typo in hull that I think we didn't catch before because of some creepy Python scoping (sometimes disaggregatedVar was a thing--I'm not sure what.)
  • Adds a test.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt
Copy link
Contributor

mrmundt commented Jul 19, 2023

I'm mad about the fact that we had 20 PRs open twice today.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.40 ⚠️

Comparison is base (4f2d5fc) 87.82% compared to head (848ece7) 87.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
- Coverage   87.82%   87.43%   -0.40%     
==========================================
  Files         770      770              
  Lines       89637    89637              
==========================================
- Hits        78726    78375     -351     
- Misses      10911    11262     +351     
Flag Coverage Δ
linux 84.38% <0.00%> (-0.52%) ⬇️
osx 74.44% <0.00%> (-0.19%) ⬇️
other 84.56% <0.00%> (-0.52%) ⬇️
win 81.96% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/gdp/plugins/hull.py 93.52% <0.00%> (ø)

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrmundt mrmundt merged commit bc05ab3 into Pyomo:main Jul 20, 2023
28 of 30 checks passed
@emma58 emma58 deleted the hull-typo-fix branch February 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants