Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML4 Forcing in Online Docs #2949

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Aug 16, 2023

Fixes NA

Summary/Motivation:

We have been forcing HTML4 ReadTheDocs configuration due to an issue from 2021; however, that issue has been resolved.

Changes proposed in this PR:

  • Allow RTD to render HTML in whatever format it likes

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested a review from jsiirola August 16, 2023 15:44
Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like removing breadcrumbs in case this pops up again, but I know you have an aversion to leaving historical comments.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1cb37aa) 87.82% compared to head (fefbd4c) 87.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         770      770           
  Lines       89654    89654           
=======================================
  Hits        78741    78741           
  Misses      10913    10913           
Flag Coverage Δ
linux 84.86% <ø> (ø)
osx 74.58% <ø> (ø)
other 85.04% <ø> (ø)
win 82.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmundt mrmundt merged commit 915f02b into Pyomo:main Aug 17, 2023
30 checks passed
@mrmundt mrmundt deleted the docs-theme-update branch August 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants