Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a 'that' vs. 'which' mistake in error about bounds crossing #2950

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

emma58
Copy link
Contributor

@emma58 emma58 commented Aug 16, 2023

Fixes # .

Summary/Motivation:

One-word change to fix a grammar mistake in an error message.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (1cb37aa) 87.82% compared to head (a63689c) 87.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   87.82%   87.81%   -0.02%     
==========================================
  Files         770      770              
  Lines       89654    89640      -14     
==========================================
- Hits        78741    78719      -22     
- Misses      10913    10921       +8     
Flag Coverage Δ
linux 84.87% <ø> (+<0.01%) ⬆️
osx 74.57% <ø> (-0.01%) ⬇️
other 85.04% <ø> (ø)
win 82.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyomo/contrib/fbbt/fbbt.py 96.96% <ø> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmundt mrmundt merged commit 74ea4f7 into Pyomo:main Aug 17, 2023
30 checks passed
@emma58 emma58 deleted the grammar-nit branch February 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants