Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture HiGHS output when initializing model #3005

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jsiirola
Copy link
Member

Fixes #3003

Summary/Motivation:

#3003 pointed out that the APPSI HiGHS interface does not capture output that HiGHS emits when initializing the first model. This PR adds additional output capturing within set_instance(), as well as a test to verify that the output is correctly being captured.

Changes proposed in this PR:

  • Capture output emitted by HiGHS during set_instance()
  • Test this behavior (relying on subprocess to capture initial output from HiGHS)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bdbcb31) 88.10% compared to head (97d7509) 88.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3005      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.02%     
==========================================
  Files         769      769              
  Lines       89520    89525       +5     
==========================================
- Hits        78869    78862       -7     
- Misses      10651    10663      +12     
Flag Coverage Δ
linux 85.19% <92.30%> (+<0.01%) ⬆️
osx 74.99% <0.00%> (-0.01%) ⬇️
other 85.36% <92.30%> (+<0.01%) ⬆️
win 82.43% <92.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyomo/contrib/appsi/solvers/highs.py 92.35% <92.30%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit ec5c7d0 into Pyomo:main Sep 25, 2023
34 checks passed
@jsiirola jsiirola deleted the capture_highs_output branch November 27, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undesired printed output when using HiGHS solver
3 participants