Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup parmest #3028

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Cleanup parmest #3028

merged 5 commits into from
Nov 6, 2023

Conversation

smartin71
Copy link
Contributor

Fixes # .

Updated examples/tests pandas code using .iloc[0] to avoid future deprecation warning.
Updated call back functions in examples to avoid errors for different types of data (pandas dataframes, dict, file lists).
Updated graphics.py to avoid matplotlib deprecation warning.

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@smartin71 smartin71 marked this pull request as draft October 31, 2023 21:48
@smartin71
Copy link
Contributor Author

Bethany Nicholson requested this PR. I am not sure how to add reviewers.

@blnicho blnicho marked this pull request as ready for review November 1, 2023 15:07
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (00e9324) 87.87% compared to head (a79912c) 87.86%.
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
- Coverage   87.87%   87.86%   -0.01%     
==========================================
  Files         769      769              
  Lines       89522    89537      +15     
==========================================
+ Hits        78668    78675       +7     
- Misses      10854    10862       +8     
Flag Coverage Δ
linux 85.19% <78.65%> (-0.01%) ⬇️
osx 74.99% <0.00%> (-0.02%) ⬇️
other 85.37% <78.65%> (-0.01%) ⬇️
win 82.42% <78.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rmest/examples/reactor_design/bootstrap_example.py 94.73% <100.00%> (ø)
...parmest/examples/reactor_design/datarec_example.py 97.87% <100.00%> (ø)
...rmest/examples/reactor_design/leaveNout_example.py 97.56% <100.00%> (ø)
...xamples/reactor_design/likelihood_ratio_example.py 96.00% <100.00%> (ø)
...xamples/reactor_design/multisensor_data_example.py 94.44% <100.00%> (ø)
...les/reactor_design/parameter_estimation_example.py 96.00% <100.00%> (ø)
.../parmest/examples/reactor_design/reactor_design.py 92.68% <84.61%> (-4.29%) ⬇️
pyomo/contrib/parmest/graphics.py 86.34% <90.90%> (ø)
...mo/contrib/parmest/examples/semibatch/semibatch.py 94.44% <78.57%> (-4.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit 2709a6d into Pyomo:main Nov 6, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants