Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary __future__ imports #3109

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jan 26, 2024

Fixes NA

Summary/Motivation:

There were some leftover imports that are unnecessary since we no longer support Python2.

Changes proposed in this PR:

  • Remove from __future__ import *
  • Update comments, as necessary

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one comment I think we should leave

pyomo/core/expr/numvalue.py Outdated Show resolved Hide resolved
@mrmundt mrmundt requested a review from blnicho January 26, 2024 20:02
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00748f4) 88.27% compared to head (1dfefb5) 88.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3109      +/-   ##
==========================================
- Coverage   88.27%   88.26%   -0.01%     
==========================================
  Files         832      832              
  Lines       92332    92301      -31     
==========================================
- Hits        81505    81474      -31     
  Misses      10827    10827              
Flag Coverage Δ
linux 86.02% <100.00%> (-0.01%) ⬇️
osx 75.53% <100.00%> (-0.01%) ⬇️
other 86.20% <100.00%> (-0.01%) ⬇️
win 83.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit f7fa223 into Pyomo:main Jan 26, 2024
33 checks passed
@blnicho blnicho deleted the residual-python2 branch January 26, 2024 21:43
@@ -1,7 +1,7 @@
# stochastic pde model for natural gas network
# victor m. zavala / 2013

# from __future__ import division
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this? It looks like a stray "#"

@@ -1,7 +1,7 @@
# stochastic pde model for natural gas network
# victor m. zavala / 2013

# from __future__ import division
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants