Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Version Update: Address node.js deprecations #3118

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Feb 1, 2024

Fixes # .

Summary/Motivation:

There are new versions of all actions that use node.js. This addresses deprecation warnings.

Changes proposed in this PR:

  • Update action versions

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should actions/upload-artifact@v3 also be updated to actions/upload-artifact@v4?

@mrmundt mrmundt requested a review from blnicho February 1, 2024 19:17
@mrmundt
Copy link
Contributor Author

mrmundt commented Feb 1, 2024

Should actions/upload-artifact@v3 also be updated to actions/upload-artifact@v4?

Yup, I missed that one. Updated!

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5aca8b) 88.29% compared to head (1d243ba) 88.30%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3118   +/-   ##
=======================================
  Coverage   88.29%   88.30%           
=======================================
  Files         832      832           
  Lines       92234    92234           
=======================================
+ Hits        81438    81446    +8     
+ Misses      10796    10788    -8     
Flag Coverage Δ
linux 86.05% <ø> (ø)
osx 75.55% <ø> (ø)
other 86.25% <ø> (+0.02%) ⬆️
win 83.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit 3566837 into Pyomo:main Feb 1, 2024
33 checks passed
@blnicho blnicho deleted the update-action-versions branch February 1, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants