-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code for infeasibility diagnostics called mis #3172
Conversation
fixing _get_constraint test
Some tests seem to be failing due to infrastructure issues (e.g. an Xpress license seized the once-every-four-years opportunity to expire on Feb 29!) |
Infrastructure issues have been fixed - I merged the changes into your branch. |
Now that the infrastructure issues are fixed (Thanks!) some tests are failing due to contention for temp files, but only on windows platforms. I will try to get some help with this. |
@DLWoodruff @bknueven would either of you be able to attend a future Pyomo dev meeting to talk about this PR? We're curious if this should be added as an alternative in |
I would be able to attend -- though next week is not good. I agree that this capability should probably be folded into |
…ogger file handle
Co-authored-by: Miranda Mundt <55767766+mrmundt@users.noreply.github.com>
simplifying the code
All conversations have been resolved. Thanks again for the thorough review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @DLWoodruff ! I did another pass and have some more comments (that are mostly stylistic/quality)
All conversations have been resolved and thanks again for the thorough and constructive reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small string formatting fix, otherwise this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the Pypy test failure is unrelated, this looks good to me
Fixes # .
Summary/Motivation:
Finds sets of actions that each, independently,
would result in feasibility. It also computes a minimal intractable system
(which is not guaranteed to be unique). It was written by Ben Knueven
as part of the watertap project and is governed by a license shown
at the top of the
mis.py
.The algortithms come from John Chinneck's slides, see: https://www.sce.carleton.ca/faculty/chinneck/docs/CPAIOR07InfeasibilityTutorial.pdf
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: