-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Solver Refactor - Allow no objective #3181
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
=======================================
Coverage 88.38% 88.39%
=======================================
Files 846 846
Lines 94978 95043 +65
=======================================
+ Hits 83947 84009 +62
- Misses 11031 11034 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @mrmundt. I left one comment below.
Fixes NA (but this is mentioned in #2574)
Summary/Motivation:
There was a bug reported in #2574 (comment) that points out that you can't use
ipopt_v2
to solve something without an objective, which you technically can do inv1
. This fixes that bug.Changes proposed in this PR:
problem
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: