Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow APPSI's cmodel to handle non-mutable parameters in variable and constraint bounds #3182

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

bknueven
Copy link
Contributor

@bknueven bknueven commented Mar 7, 2024

Fixes #2574

Summary/Motivation:

See #2574

Changes proposed in this PR:

  • Add test which fails on main.
  • Check if pyomo Param is mutable or not when creating the cmodel and create a Constant object if it is not mutable.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@michaelbynum michaelbynum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bknueven!

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (56a8380) to head (b09b307).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3182   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         846      846           
  Lines       94974    94974           
=======================================
+ Hits        83941    83945    +4     
+ Misses      11033    11029    -4     
Flag Coverage Δ
linux 86.33% <ø> (ø)
osx 76.15% <ø> (ø)
other 86.52% <ø> (ø)
win 83.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelbynum michaelbynum merged commit 00adb80 into Pyomo:main Mar 8, 2024
33 checks passed
@bknueven bknueven deleted the issue-2574 branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appsi fbbt KeyError when Var bounded by Param
3 participants