Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentData backwards compatibility #3253

Merged
merged 10 commits into from
May 4, 2024

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented May 3, 2024

Fixes # .

Summary/Motivation:

This resolved several backwards compatibility issues introduced in #3221:

Changes proposed in this PR:

  • resolve a bug in RenamedClass where it failed when a class that derived off the renamed class had multiple base classes
  • the implementation of declare_custom_block used meta classes, which conflicted with the use of meta classes in RenamedClass. This removes the use of meta classes in declare_custom_block
  • re-add a deprecation path for pyomo_constant_types in pyomo.core.expr.numvalue

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola requested a review from blnicho May 3, 2024 19:20
Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a minor typo in a class name used for testing but it's not impacting functionality so it's up to you if it's worth fixing or not.

pyomo/core/tests/unit/test_block.py Outdated Show resolved Hide resolved
@jsiirola jsiirola merged commit 9dd854b into Pyomo:main May 4, 2024
33 checks passed
@jsiirola jsiirola deleted the component-data-compatability branch May 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants