Resolve bugs in create_node_with_local_data #3376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
IDAES/idaes-pse#1454 found bugs in
ExpressionData
's implementation ofcreate_node_with_local_data()
. In particular,ScalarExpression.create_node_with_local_data
was returning an unconstructedScalarExpression
. This PR resolves that bug (and another found when debuggingcreate_node_with_local_data
)Changes proposed in this PR:
ExpressionData.create_node_with_local_data
: always return a bareExpressionData
object, even if the original Expression was aScalarExpression
.MonomialTermExpression.create_node_with_local_data
was ignoring the user-specified classtype argumentLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: