Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Python 3.4 Build Issues on Appveyor #438

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Resolve Python 3.4 Build Issues on Appveyor #438

merged 4 commits into from
Apr 24, 2018

Conversation

whart222
Copy link
Member

Fixes

  • Resolves build issue for Appveyor.

Summary/Motivation:

  • Updated Appveyor config file.

Changes proposed in this PR:

  • Removing conda update, which was taking too long.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@whart222 whart222 requested a review from jsiirola April 22, 2018 02:50
@whart222 whart222 changed the title Issue 432 Resolve Python 3.4 Build Issues on Appveyor Apr 22, 2018
@codecov-io
Copy link

codecov-io commented Apr 22, 2018

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files         487      487           
  Lines       63180    63180           
=======================================
  Hits        41928    41928           
  Misses      21252    21252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e6068...80b5299. Read the comment docs.

Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not quite understand the fix. The comment implies that we are "disabling the update", but the change doesn't actually disable the update.

.appveyor.yml Outdated
@@ -71,8 +71,10 @@ install:
#
# Update conda, then force it to NOT update itself again
#
# Somehow, the update stalls for Python 3.4, so we're disabling it for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem to match the remark below: you are not disabling the update, just removing the explicit tie to the Anaconda channel. Either we should remove line 77 below, or correct this comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@whart222 whart222 merged commit fd2bd02 into master Apr 24, 2018
@blnicho blnicho deleted the issue_432 branch April 24, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants