-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Python 3.4 Build Issues on Appveyor #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 487 487
Lines 63180 63180
=======================================
Hits 41928 41928
Misses 21252 21252 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not quite understand the fix. The comment implies that we are "disabling the update", but the change doesn't actually disable the update.
.appveyor.yml
Outdated
@@ -71,8 +71,10 @@ install: | |||
# | |||
# Update conda, then force it to NOT update itself again | |||
# | |||
# Somehow, the update stalls for Python 3.4, so we're disabling it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't seem to match the remark below: you are not disabling the update, just removing the explicit tie to the Anaconda channel. Either we should remove line 77 below, or correct this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: