Fix/override button style #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextButton style merge is implemented in a way that the original object takes precedence over the argument. We therefore switch the merge orientation to ensure that it is possible to override every style. Closes Pyozer#224
|
i was able to reproduce (and fix) the build error once i've upgraded my local flutter version to stable. |
…support current flutter / dart version Update Android build tooling: - Bump Android Gradle Plugin from 7.3.0 to 8.1.0 - Upgrade Gradle wrapper from 7.6.3 to 8.0
lukengda
force-pushed
the
fix/override-button-style
branch
from
8fd0bfb to
f758b55
Compare
|
it seems to be working now, Java 17 and flutter upgrade did the job.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Herby, i propose the following changes to solve #224. While we're at it, i've improved and added a bit to the tests.
I have taken the liberty of adding a version increment if a release of this fix is being considered. Let me know if you need something to get this going. Thank you very much!