-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/remove-secret-encryption-experimental #201
Refactor/remove-secret-encryption-experimental #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better adding the until
?
Tests are failing due to Ansible lint failures unrelated to this PR. If you'd like I can help fix those? 🙂 |
Hey @onedr0p - Would you be able to PR this? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look fine, and Ansible lint is broken due to updates to Ansible itself. I would merge this however I'm not sure how to cut a release, and maybe the lint errors should be fixed too.
Thanks a lot for taking a look @onedr0p 🙂 - I started working on fixing the lint issues in #202 but I was awaiting feedback on some of the task names. |
Remove secret-encryption as experimental
Summary
Fixes #200. The
secret-encryption
is no longer an experimental feature.Issue type
Additional Information
Please let me know if there is anything else I need to change. I'm not sure whether the
k3s_use_experimental
variable inmolecule/highavailabilityetcd/converge.yml
needs removing because of this change.