-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow attr_list quoted values to contain curly braces #1414
Merged
Commits on Nov 11, 2023
-
Allow attr_list quoted values to contain curly braces
How it worked before: * Extract the content without allowing any `}` in it, and require that it ends with `}` - for block elements anchored to the end of the line, otherwise not. * Parse the content in more detail. No edge cases with `}` can arise. If parsing is interrupted by some unrecognized token, discard the rest of the string. How it works now: * Extract the content *and allow* `}` in it, and require that it ends with `}` - for block elements it's anchored to the end of the line, otherwise not. * Parse the content in more detail. Allow `}` only within the quoted parts, otherwise interrupt parsing like for any other unrecognized token. If parsing is interrupted, there is remaining unrecognized text. Ideally perhaps we would bail out at this point entirely (and not recognize it as an attr_list), but to preserve historic behavior, any extra text before `}` is just discarded. If there is an extra `}` in the remaining text: * For block elements: that must mean that the attr_list syntax did not in fact terminate at the end of the line but earlier. So, bail out and do not register any attributes and do not change the original text. * For inline elements: that must mean that we just overmatched a bit, but that's OK, we just assign attrs as normal and put the extra text back into the string. As mentioned, any extra text *before* `}` is just discarded.
Configuration menu - View commit details
-
Copy full SHA for d015e31 - Browse repository at this point
Copy the full SHA d015e31View commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c610585 - Browse repository at this point
Copy the full SHA c610585View commit details -
Configuration menu - View commit details
-
Copy full SHA for d53cc1b - Browse repository at this point
Copy the full SHA d53cc1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6201f6d - Browse repository at this point
Copy the full SHA 6201f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1d621 - Browse repository at this point
Copy the full SHA 8e1d621View commit details -
Configuration menu - View commit details
-
Copy full SHA for b35a200 - Browse repository at this point
Copy the full SHA b35a200View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6530e - Browse repository at this point
Copy the full SHA 4c6530eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a7fb4 - Browse repository at this point
Copy the full SHA d8a7fb4View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb1ddba - Browse repository at this point
Copy the full SHA cb1ddbaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.