Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attr_list quoted values to contain curly braces #1414

Merged
merged 9 commits into from
Mar 12, 2024

Commits on Nov 11, 2023

  1. Allow attr_list quoted values to contain curly braces

    How it worked before:
    
      * Extract the content without allowing any `}` in it, and require that it ends with `}` - for block elements anchored to the end of the line, otherwise not.
      * Parse the content in more detail. No edge cases with `}` can arise. If parsing is interrupted by some unrecognized token, discard the rest of the string.
    
    How it works now:
    
      * Extract the content *and allow* `}` in it, and require that it ends with `}` - for block elements it's anchored to the end of the line, otherwise not.
      * Parse the content in more detail. Allow `}` only within the quoted parts, otherwise interrupt parsing like for any other unrecognized token.
        If parsing is interrupted, there is remaining unrecognized text. Ideally perhaps we would bail out at this point entirely (and not recognize it as an attr_list), but to preserve historic behavior, any extra text before `}` is just discarded.
        If there is an extra `}` in the remaining text:
          * For block elements: that must mean that the attr_list syntax did not in fact terminate at the end of the line but earlier. So, bail out and do not register any attributes and do not change the original text.
          * For inline elements: that must mean that we just overmatched a bit, but that's OK, we just assign attrs as normal and put the extra text back into the string. As mentioned, any extra text *before* `}` is just discarded.
    oprypin committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d015e31 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    c610585 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d53cc1b View commit details
    Browse the repository at this point in the history
  3. Add fenced_code test

    waylan committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6201f6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e1d621 View commit details
    Browse the repository at this point in the history
  5. Changelog

    oprypin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b35a200 View commit details
    Browse the repository at this point in the history
  6. coverage

    waylan committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4c6530e View commit details
    Browse the repository at this point in the history
  7. fix spelling

    waylan committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d8a7fb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Docs cleanup

    waylan committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    cb1ddba View commit details
    Browse the repository at this point in the history