Add Speakers talk excerpt field #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virogenesis
requested changes
Jun 19, 2018
There was a problem hiding this comment.
Hi @nadaj , do you think maybe that we should have the excerpt as a markdown field it might help with styling the frontend a bit :)
ulgens
reviewed
Jun 20, 2018
| @@ -0,0 +1,19 @@ | |||
| # Generated by Django 2.0.5 on 2018-06-20 06:07 | |||
There was a problem hiding this comment.
Not a big deal but naming convention for file names is all-lowercase with underscores. The same applies to other PR with migration.
There was a problem hiding this comment.
No problem, I'll fix that in both PRs and push the change.
|
@nadaj can you add the admin part aswell so we can add content to the model ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.