Skip to content

Commit

Permalink
Revert "fix: disable text reports for now (apache#16257)" (apache#16296)
Browse files Browse the repository at this point in the history
This reverts commit ee9a384.
  • Loading branch information
betodealmeida authored Aug 17, 2021
1 parent cf8f1a3 commit 207bc4e
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 2 deletions.
7 changes: 6 additions & 1 deletion superset-frontend/src/components/ReportModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ type ReportActionType =
};

const DEFAULT_NOTIFICATION_FORMAT = 'TEXT';
const TEXT_BASED_VISUALIZATION_TYPES: string[] = [];
const TEXT_BASED_VISUALIZATION_TYPES = [
'pivot_table',
'pivot_table_v2',
'table',
'paired_ttest',
];

const reportReducer = (
state: Partial<ReportObject> | null,
Expand Down
16 changes: 16 additions & 0 deletions superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,22 @@ describe('AlertReportModal', () => {
expect(wrapper.find(Radio)).toHaveLength(2);
});

it('renders text option for text-based charts', async () => {
const props = {
...mockedProps,
alert: mockData,
};
const textWrapper = await mountAndWait(props);

const chartOption = textWrapper.find('input[value="chart"]');
act(() => {
chartOption.props().onChange({ target: { value: 'chart' } });
});
await waitForComponentToPaint(textWrapper);

expect(textWrapper.find('input[value="TEXT"]')).toExist();
});

it('renders input element for working timeout', () => {
expect(wrapper.find('input[name="working_timeout"]')).toExist();
});
Expand Down
7 changes: 6 additions & 1 deletion superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ import {

const SELECT_PAGE_SIZE = 2000; // temporary fix for paginated query
const TIMEOUT_MIN = 1;
const TEXT_BASED_VISUALIZATION_TYPES: string[] = [];
const TEXT_BASED_VISUALIZATION_TYPES = [
'pivot_table',
'pivot_table_v2',
'table',
'paired_ttest',
];

type SelectValue = {
value: string;
Expand Down

0 comments on commit 207bc4e

Please sign in to comment.