fix: Disable lazy loading for the Database selector (apache#16908)

* fix: Disable lazy loading for the Database selector * Fixes the tests
QAlexBall · Sep 30, 2021 · 7aa59c3 · 7aa59c3
1 parent a5914c7
commit 7aa59c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx b/superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
@@ -180,7 +180,7 @@ test('Refresh should work', async () => {
   userEvent.click(select);
 
   await waitFor(() => {
-    expect(SupersetClientGet).toBeCalledTimes(1);
+    expect(SupersetClientGet).toBeCalledTimes(2);
     expect(props.getDbList).toBeCalledTimes(0);
     expect(props.getTableList).toBeCalledTimes(0);
     expect(props.handleError).toBeCalledTimes(0);
@@ -193,8 +193,8 @@ test('Refresh should work', async () => {
   userEvent.click(screen.getByRole('button', { name: 'refresh' }));
 
   await waitFor(() => {
-    expect(SupersetClientGet).toBeCalledTimes(2);
-    expect(props.getDbList).toBeCalledTimes(0);
+    expect(SupersetClientGet).toBeCalledTimes(3);
+    expect(props.getDbList).toBeCalledTimes(1);
     expect(props.getTableList).toBeCalledTimes(0);
     expect(props.handleError).toBeCalledTimes(0);
     expect(props.onDbChange).toBeCalledTimes(0);

diff --git a/superset-frontend/src/components/DatabaseSelector/index.tsx b/superset-frontend/src/components/DatabaseSelector/index.tsx
@@ -253,6 +253,7 @@ export default function DatabaseSelector({
         ariaLabel={t('Select database or type database name')}
         data-test="select-database"
         header={<FormLabel>{t('Database')}</FormLabel>}
+        lazyLoading={false}
         onChange={changeDataBase}
         value={currentDb}
         placeholder={t('Select database or type database name')}