Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new PCX image loader and add tests #513

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Implement new PCX image loader and add tests #513

merged 7 commits into from
Jun 25, 2024

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Jun 23, 2024

This PR fixes the .pcx image loader issue reported here.

It has the following changes:

  • New .pcx image loader
  • Adds tests for most PCX sub-format: 1bpp, 2bpp, 4bpp, 8bpp and 24bpp
  • Moves some inline colors functions out of qbx.cpp to image.h
  • Updates library files to latest versions: stb_image, nanosvg

@a740g a740g added bug Something isn't working enhancement New feature or request labels Jun 23, 2024
@a740g a740g self-assigned this Jun 23, 2024
@a740g a740g merged commit 91a25d3 into QB64-Phoenix-Edition:main Jun 25, 2024
4 checks passed
@a740g a740g deleted the pcx-fixes branch June 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flukiluke flukiluke flukiluke approved these changes

@RhoSigma-QB64 RhoSigma-QB64 RhoSigma-QB64 approved these changes

@grymmjack grymmjack Awaiting requested review from grymmjack

@mkilgore mkilgore Awaiting requested review from mkilgore

@SteveMcNeill SteveMcNeill Awaiting requested review from SteveMcNeill

Assignees

@a740g a740g

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a740g @flukiluke @RhoSigma-QB64