Fix shared directory state between KILL, FILES, and _FILES$ #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a740g
requested review from
grymmjack,
mkilgore,
flukiluke,
SteveMcNeill and
RhoSigma-QB64
RhoSigma-QB64
approved these changes
Oct 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where KILL, FILES, and _FILES$ unintentionally shared a static
DIRpointer when performing file searches. As a result, calling any of these functions would reset the search state of _FILES$, leading to unexpected behavior.Each of these functions (KILL, FILES, and _FILES$) now maintains its own separate directory search state, preventing interference between them.
This issue was reported here.