Set scale_factor=2 only if both Retina and 5K

[JoeyLemur]

On older Macs that have a 2880 x 1800 Retina display, setting scale_factor=2 makes the IDE far too large. This minor logic change will only set scale to x2 if it detects both Retina and 5K.

[FellippeHeitor]

Is the issue happening in Catalina? Also, making the change will exclude cases where only one of the indicators appears.

[JoeyLemur]

Yes, this is on my Catalina system. My thought is that it shouldn't scale by x2 unless it finds 'Retina' and '5K' in the 'system_profiler SPDisplaysDataType' output, and it does fix the scaling issue on my MBP 15" (mid-2015).

I probably should've done this before I submitted the PR, but when I get some time today, I'll throw Catalina onto a drive and see what happens on my 2109 MBP 16" -- its already on Big Sur, and doesn't have scaling problems, either with or without this PR.

[familygw]

Yes, this is on my Catalina system. My thought is that it shouldn't scale by x2 unless it finds 'Retina' and '5K' in the 'system_profiler SPDisplaysDataType' output, and it does fix the scaling issue on my MBP 15" (mid-2015).

I probably should've done this before I submitted the PR, but when I get some time today, I'll throw Catalina onto a drive and see what happens on my 2109 MBP 16" -- its already on Big Sur, and doesn't have scaling problems, either with or without this PR.

Hi!
Can you share your “ system_profiler SPDisplaysDataType”?
Retina appears for system with integrated displays, and 5K when you use external UHD/4K monitors (for example on MacPro or MacMini).

Also share the output for “uname -a” from your Catalina’s system.

Maybe a good approach will be to identify the resolution on “retina” displays.
Thanks!!

[flukiluke]

Is this still relevant? Do we need more data?