-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swabian Instruments Time Tagger driver #331
base: main
Are you sure you want to change the base?
Swabian Instruments Time Tagger driver #331
Conversation
To Do: - Document API - Document driver design - Write example
These clear the ChannelList objects that are populated using the add_{xxx}_{yyy} methods
Required if multiple Measurement channel objects with __channels_proxy parameter are used with qcodes' datasaver.add_result()
I have no idea why mypy errors here, maybe someone can help out. |
@thangleiter Looks like this needs a bit of work on the type checking with mypy. Let me know if you run into any issues with that |
Thanks, I could indeed use some help with the error that mypy has in the 3.9 run. The
I will get to work on the other Python versions, although this is the first time I have mypy giving different errors for different versions. Let's see if the fixes don't break the other versions. |
Still don't understand why it did not work the way I typed it but it should be fixed now in any case 👍 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 10.86% 10.64% -0.22%
==========================================
Files 133 135 +2
Lines 17741 18106 +365
==========================================
Hits 1928 1928
- Misses 15813 16178 +365 ☔ View full report in Codecov by Sentry. |
Hey @jenshnielsen, this is good to go from my side |
This PR adds a driver for the Swabian Intsruments Time Tagger.
See the module docstring for design decisions.