[ZIP-233] Network Sustainability Mechanism: Burning #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ording zcash_client_sqlite: Track all transparent spends.
zcash_protocol release version 0.2.0
release zcash_encoding version 0.2.1
zcash_address: release version 0.4.0
zcash_primitives: Release version 0.16.0
zcash_proofs: Release version 0.16.0
zcash_keys: release version 0.3.0
release zip321 version 0.1.0
zcash_client_backend: Add `tor::Client::connect_to_lightwalletd`
…-0.13.0 release zcash_client_backend version 0.13.0
…0.11.0 release zcash_client_sqlite version 0.11.0
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
zcash_client_backend: Remove deprecated and duplicative wallet APIs.
Add `merge_group:` trigger to CI workflow.
This enables us to add a single "required status check" to the GitHub repo settings, that covers all required matrix job cases.
CI: Add a job that runs when all required status checks pass
RPIT (return-position `impl Trait`) was stabilized in Rust 1.75, and the `dynosaur` crate providing dynamic dispatch support was published two weeks ago. Now that our MSRV is 1.77, we can use both of these.
zcash_client_backend: Switch from `async-trait` to RPIT for `tor` module
…ork before (most) migrations.
zcash_client_sqlite: Verify that the database is for the correct network before (most) migrations.
…2.x' into hotfix/zcash_client_sqlite-0.12.x-merge
….12.x-merge Merge hotfix/zcash_client_sqlite-0.12.x back to `main`.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…test profile to compile with optimizations by default, but keep full debug info. This differs from the release profile in the following ways: - it does not set `lto = true`, which increases compile times without substantially speeding up tests; - it does not set `codegen-units = 1`, which increases compile times and is only useful to improve determinism of release builds; - it does not set `panic = 'abort'`, which is in any case ignored for tests. After this PR, to get results as close as possible to a release build, use `cargo test --release`. To speed up compilation and avoid optimizations potentially resulting in lower-quality debug info, use `cargo test --profile=dev`. Times on my machine starting from `cargo clean` for each run: * `cargo test --all-targets --all-features`: * 484s (354s build, 130s tests) * `cargo test --release --all-targets --all-features`: * 541s (415s build, 126s tests) * `cargo test --profile=dev --all-targets --all-features`: * 1709s (146s build, 1563s tests) * this might still be faster when running individual tests. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
(instead of only in CI), so that there is no need to set it manually. You can override this by setting `RUST_BACKTRACE=0`, or `RUST_BACKTRACE=full` for a full backtrace. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Dev quality-of-life improvements (better test backtraces in CI and locally; faster test builds; `RUST_BACKTRACE=1` by default)
|
Sorry, opened with the wrong branch 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the
librustzcashchanges required for ZIP-233 (NSM - Burning), which adds a transaction field forburnAmount. This is essentially a copy of zcash#1567 that I'm posting here for convenience. Unfortunately this also includes a diff with upstream. It briefly tried rebasing on thezsa1branch, but it looks like it could be messy. However, I can take some time to do this if you'd rather not merge with upstreamlibrustzcashat this time?