Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reference notes #94

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Adding reference notes #94

merged 4 commits into from
Jan 8, 2025

Conversation

vivek-arte
Copy link

This PR adds the specification of reference notes, which are to be created at the time of first issuance of a Custom Asset. Alongside, we also update the issuance state and consensus rules to account for these changes.

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit c531fc9
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/677e79ffb640700008d4cdaf
😎 Deploy Preview https://deploy-preview-94--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Author

@vivek-arte vivek-arte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider these comments as well while reviewing.

zips/zip-0227.rst Outdated Show resolved Hide resolved
zips/zip-0227.rst Outdated Show resolved Hide resolved
zips/zip-0227.rst Outdated Show resolved Hide resolved
zips/zip-0227.rst Outdated Show resolved Hide resolved
@vivek-arte vivek-arte added the ZSAs label Jan 4, 2025
@vivek-arte vivek-arte requested a review from PaulLaux January 4, 2025 08:51
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

zips/zip-0227.rst Outdated Show resolved Hide resolved
zips/zip-0227.rst Show resolved Hide resolved
@vivek-arte vivek-arte force-pushed the add_ref_notes_to_spec branch from 7f04bb8 to c531fc9 Compare January 8, 2025 13:13
@vivek-arte vivek-arte merged commit 2ef0f1a into zsa1 Jan 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants