Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGEP SWMM raingages export #646

Open
tproduit opened this issue Mar 30, 2021 · 8 comments
Open

QGEP SWMM raingages export #646

tproduit opened this issue Mar 30, 2021 · 8 comments
Labels

Comments

@tproduit
Copy link

Currently one raingage per subcatchment is exported. Then, the user can assign the same rain to each raingages. However, the most common case would a single raingage for the entire study area.

In special cases, if the study area is very hilly and extended the user could then choose to add more raingages manually.

@sjib
Copy link
Contributor

sjib commented Mar 31, 2021

@DflGruBoe @kfischerar @urskaufmann What do you think about this. How many raingauges do you need in your projects?

@sjib sjib added the SWMM label Mar 31, 2021
@urskaufmann
Copy link

Till now the problem was, how many raingauges with good data are available in a study area. I have always defined the raindata in the hydraulic program, not in the vsa-dss database.

@tproduit
Copy link
Author

tproduit commented May 18, 2022

Feedback from technical group:

  • Literature shows that using several raingages provides more realistic results

  • If raingages are inserted in QGEP (measuring_point):

    • the user can choose which rainage is exported
    • or the catchments can be linked to nearest raingage

Proposition:
We keep the current export (one raingage per catchment and document well how the raingages can be deleted and / linked to rain curve. We wait for other user feedbacks to decide if another strategy is better.

@ponceta
Copy link
Member

ponceta commented Mar 14, 2023

@tproduit is the proposition added to the documentation?

@TriformMoritz do you agree with such strategy?

@tproduit
Copy link
Author

Current export of rain gages works like this. It is documented in the PR

QGEP_SWMM creates one raingage for each subcatchment.

By default:

  • Time serie: Each raingage is related to a default rain time serie called default_qgep_raingage_timeserie. The time serie must be created and the value Series Name updated accordingly.
  • Other parameters have default SWMM values

See vw_swmm_raingages.sql for details.

@ponceta
Copy link
Member

ponceta commented Mar 14, 2023

To be closed as soon as doc PR is merged !

@TriformMoritz
Copy link

I usually use only one rain for the whole area for one typical rain event (with a given retourn time amd a typical curve). So I would leave it as default.
Various raingages are for interesting if you use real measurements of an event in an area or long time series (LTS), I would do this normally in SWMM (like Urs said).

So my recommandation:

  • Leave the default default_qgep_raingage_timeserie and link every catchment to the raingage (like it is done right now).
  • Bonus 1: Make this "default rain" raingage visible in QGIS (so you can modify it inside QGIS for all catchments).
  • Bonus 2: Leave the option to create and link other raingages and export them.

So if I understand Timothee, this is how it will work!

@cymed
Copy link

cymed commented Oct 20, 2023

I agree with @TriformMoritz. This also treats the bug that two raingages are created for a catchment if it is connected to fresh- and wastewater

cymed added a commit to cymed/datamodel that referenced this issue Oct 25, 2023
creates one raingage per status instead of one raingage per subchatchment. See QGEP/QGEP#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants