Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.5.8 delta for multiple vsacodes #218

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix 1.5.8 delta for multiple vsacodes #218

merged 1 commit into from
Jul 17, 2023

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented May 2, 2023 •
edited by sjib
Loading

SELECT DISTINCT vsacode for multiple vsacodes

Fix :

@ponceta
SELECT DISTINCT vsacode
a4b2a91 
SELECT DISTINCT vsacode
@ponceta ponceta added the bug Due to something that is not working as expected label May 2, 2023
@ponceta ponceta self-assigned this May 2, 2023
@sjib sjib mentioned this pull request May 19, 2023
Open
3 tasks
@ponceta ponceta closed this Jun 14, 2023
@ponceta ponceta reopened this Jun 14, 2023
ponceta added a commit to VilleDePully/datamodel that referenced this pull request Jun 14, 2023
@ponceta
Update delta_1.5.8_tbl_swmm_coefficient_friction.sql
03e0906 
Ref QGEP#218
@ponceta ponceta closed this Jul 17, 2023
@ponceta ponceta reopened this Jul 17, 2023
@ponceta ponceta closed this Jul 17, 2023
@ponceta ponceta reopened this Jul 17, 2023
@ponceta
Copy link
Member Author

ponceta commented Jul 17, 2023

@RoMabillard is it OK for you to add the DISTINCT keyword here?

@ponceta ponceta requested a review from cymed July 17, 2023 09:55
cymed
cymed approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@cymed cymed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@ponceta ponceta merged commit 40788ae into master Jul 17, 2023
@ponceta ponceta deleted the poa_fix_delta_1.5.8_mutliple_vsacodes branch July 17, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cymed cymed cymed approved these changes

Assignees

@ponceta ponceta

Labels
bug Due to something that is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponceta @cymed