Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification via unlocking measurement report when set to readonly #125

Open
4 tasks done
che85 opened this issue Jan 10, 2017 · 8 comments
Open
4 tasks done
Assignees

Comments

@che85
Copy link
Member

che85 commented Jan 10, 2017

Users should be allowed to unlock a readonly measurement report. Of the following things need to be taken care:

  • don't touch the original measurement report or segmentation
    • create a copy of the table node
    • create a copy of the segmentation node and reference the copy in the new table node
  • user can always go back an force via selecting original/copy in measurement selector
@che85 che85 added this to the NAMIC-Winter2017 milestone Jan 10, 2017
@che85 che85 self-assigned this Jan 10, 2017
@che85
Copy link
Member Author

che85 commented Jan 10, 2017

@fedorov Did I forget something? Feel free to add bullet points

@che85
Copy link
Member Author

che85 commented Jan 10, 2017

We might need to handle it differently based on the completion status, where continuing a just "saved" report can be continued and a "completed" cannot.

che85 added a commit to che85/Reporting that referenced this issue Jan 10, 2017
…CR#125):

- a copy of table node and segmentation node will be created and referenced
- appending _copy to segmentation and table node names
@fedorov
Copy link
Member

fedorov commented Jan 11, 2017

I am not sure it makes sense to create a copy of the measurements table, since we may not be able to recompute the original measurements. I think to me it would be more intuitive if on report modification the table is reset, user is allowed to modify segmentation, which would then be saved into a new DICOM object, and measurements table is recomputed.

@che85
Copy link
Member Author

che85 commented Apr 25, 2017

@fedorov Shall we close this issue or do we want to provide this functionality?

@fedorov
Copy link
Member

fedorov commented Apr 25, 2017

I think it would be good to provide this functionality, but it is not a high priority.

@che85
Copy link
Member Author

che85 commented Jan 3, 2018

@fedorov I don't know if this feature is required. It was implemented in che85@d88717f but never merged into master

@fedorov
Copy link
Member

fedorov commented Jan 3, 2018

Yes, I am not sure there was a PR. Let's not worry about it for now - let's resolve bugs and features that are needed for @chribaue use cases, and switch to PI-RADS.

@che85
Copy link
Member Author

che85 commented Jan 3, 2018

Ok great. I just wanted to go through all issues and close those ones that have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants