Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check validity of the measurement before passing it to tid1500writer #186

Open
fedorov opened this issue Aug 24, 2017 · 1 comment
Open

Comments

@fedorov
Copy link
Member

fedorov commented Aug 24, 2017

Some of the measurements sometime can have invalid values. As an example, peak measurements produced by the PET plugin will be "nan" for small volumes.

Maybe it will be good to check if the quantity produced by the plugin is a number, and if it is not - not copy it to the JSON to be passed to the tid1500writer? Or maybe it will be sufficient to handle it in dcmqi to ignore such values - the error is raised in https://github.com/QIICR/dcmqi/blob/master/apps/sr/tid1500writer.cxx#L208? Or both?

Related issue that I am not sure we discussed before: need to test what will be the behavior of the table if there are different sets of measurements for different rows.

fedorov added a commit to fedorov/dcmqi that referenced this issue Aug 24, 2017
This came up with "nan" generated by PET measurements plugin.

Related issue: QIICR/QuantitativeReporting#186
fedorov added a commit to fedorov/dcmqi that referenced this issue Aug 24, 2017
This came up with "nan" generated by PET measurements plugin.

Related issue: QIICR/QuantitativeReporting#186
@lassoan
Copy link
Collaborator

lassoan commented Aug 24, 2017

When a table column is set to floating-point type then it can store NAN values. It can be entered to the table as "nan", and currently displayed as "1.#QNAN" but we can change the implementation so that it is displayed and can be entered as an empty string.

For integer types there is no special value for missing data in most programming languages. In Slicer tables, there is a default value specified for each column (that is used when you create a new row), which could be used as a placeholder for missing data. We could also quite easily add another "empty value", which would be displayed as en empty string in the table.

@che85 che85 added this to the NAMIC-Winter2018 milestone Jan 3, 2018
fedorov added a commit to fedorov/dcmqi that referenced this issue May 18, 2018
This came up with "nan" generated by PET measurements plugin.

Related issue: QIICR/QuantitativeReporting#186
che85 pushed a commit to che85/dcmqi that referenced this issue May 10, 2020
This came up with "nan" generated by PET measurements plugin.

Related issue: QIICR/QuantitativeReporting#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants