-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master volume selector is editable after loading from SR #194
Comments
referenceImageGeometryRef is not set properly when loading from DICOM. Will look into that. |
@fedorov When loading a segmentation into Slicer the user is required to select referenced series (if available) that will be loaded next to the segmentation into Slicer. Assuming that both of the following series get loaded into Slicer, how would we know which one to set as the referenceImageGeometryRef? One issue is, that both series and How do you want to handle this situation? |
The attributes UID/DICOM* are initialized by SubjectHierarchy somehow. Instead, we should use the attributes initialized by the DICOM plugins: https://github.com/QIICR/Slicer-PETDICOMExtension/blob/master/DICOMRWVMPlugin/DICOMRWVMPlugin.py#L280. This can be used to differentiate between the original PET volume, and the SUV-corrected PET volume, and prefer the SUV-corrected one as "the more important". |
Subject hierarchy itself knows nothing about DICOM tags of course, all tags are initialized by the DICOM plugins. |
@cpinter does Subject hierarchy expect/rely on the presence of any DICOM tags in any specific attributes? |
To the best of my knowledge it doesn't rely on node attributes when it comes to DICOM tags, but it relies on SH item tags for certain things. These SH item attributes are populated by the DICOM import mechanism by calling this function Christian's question is completely valid though, and was something I raised myself at some point as well. I think only one of the loadables that refer to the same series should be checked when offering the references, and that should be the one with the highest confidence (which is usually the most specialized plugin that identifies a series as something it can load) |
- referenced master volume is set properly only if SEG will be loaded after referenced volumes has been loaded. This is not always the case though! In some cases scalar volume is loaded, then SEG and in the end the PET SUV, which causes the SEG to set the wrong master volume as master volume - using Subject Hierarchy for achieving querying for the referenced volume - adding references from ReferencedImageSequence besides ReferencedSeriesSequence
As discussed today with @che85, here's the proposal how to deal with this:
|
- referenced master volume is set properly only if SEG will be loaded after referenced volumes has been loaded. This is not always the case though! In some cases scalar volume is loaded, then SEG and in the end the PET SUV, which causes the SEG to set the wrong master volume as master volume - using Subject Hierarchy for achieving querying for the referenced volume - adding references from ReferencedImageSequence besides ReferencedSeriesSequence
The text was updated successfully, but these errors were encountered: