Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add bidimensional measurement support #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pieper
Copy link
Member

@pieper pieper commented Jan 2, 2023

Before, only single length types were supported (SRT G-D7FE).

This commit adds support for measurements with a long axis (SRT G-A185) and a short axis (SRG G-A186) by creating one markup line node for each axis of each measurement.

This support was added for the LNQ project, where we have ~8,700 annotated lymph nodes in ~3,200 series in SR format.

Before, only single length types were supported (SRT G-D7FE).

This commit adds support for measurements with a long axis (SRT G-A185)
and a short axis (SRG G-A186) by creating one markup line node for each
axis of each measurement.

This support was added for the LNQ project, where we have ~8,700 annotated lymph nodes
in ~3,200 series in SR format.
@pieper pieper requested a review from fedorov January 2, 2023 21:07
@pieper
Copy link
Member Author

pieper commented Jan 2, 2023

Here's an example of an SR with two bidimensional measurements. We could consider making a custom markup class for this type of measurement, but for now it's two lines. Also the name of the markup is the PersonName of the annotator, which is unknown in this data. Might be better to name based on the FindingSite and differentiate the long and short axes (or only apply the name to one of them).

image

@fedorov
Copy link
Member

fedorov commented Jan 3, 2023

Steve, thank you for the contribution. Can you share a sample? Did you validate it?

@pieper
Copy link
Member Author

pieper commented Jan 3, 2023

No, I don't have a sample I can share.

I'm not sure what you mean by validate. LIke dciodvfy?

@fedorov
Copy link
Member

fedorov commented Jan 3, 2023

Can you make a sample on a public dataset?

For validation of TID 1500 SRs, there is a specialized tool DicomSRValidator in PixelMed Toolkit (there is a note about it here: https://qiicr.gitbook.io/dcmqi-guide/opening/cmd_tools/sr/tid1500writer).

@pieper
Copy link
Member Author

pieper commented Jan 3, 2023

I can't share one of my current examples, but I've tested several and they work with this PR.

Regarding validation, I tried adding index.html as @dclunie suggested, but I don't see the validator DicomSRValidator.sh described in the dcmqi guide.

https://www.dclunie.com/pixelmed/software/index.html

Is there another place to look?

@fedorov
Copy link
Member

fedorov commented Jan 3, 2023

Steve, it is in this package pixelmedjavadicom_binaryrelease.20221004.tar.bz2, which is available under this folder https://www.dclunie.com/pixelmed/software/20221004_current/index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants