Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing of docker images #487

Closed
fedorov opened this issue Jan 3, 2024 · 3 comments
Closed

Fix publishing of docker images #487

fedorov opened this issue Jan 3, 2024 · 3 comments
Labels
bug docker

Comments

@fedorov
Copy link
Member

fedorov commented Jan 3, 2024

This appears to have been broken since 1.2.5.

https://hub.docker.com/r/qiicr/dcmqi/tags
@fedorov fedorov closed this as completed in 563b530 Jan 3, 2024
@fedorov fedorov reopened this Jan 3, 2024
@fedorov
Copy link
Member Author

fedorov commented Jan 3, 2024

After the commit above, logs say the image is pushed

image

but the latest tag in Docker Hub is still 1 year old! ..

https://hub.docker.com/repository/docker/qiicr/dcmqi/general

@michaelonken
Copy link
Member

michaelonken commented Jan 4, 2024 •
edited
Loading

Are you maybe pushing to your private docker account?
(ORG = fedorov in docker/Makefile)

fedorov added a commit that referenced this issue Jan 4, 2024
@fedorov
fix ORG for docker build
a4cfecc 
Re #487 thanks to @michaelonken!
@fedorov
Copy link
Member Author

fedorov commented Jan 4, 2024

Confirmed the new v1.3.1 release resulted in 1.3.1 docker image upload!

@fedorov fedorov closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedorov @michaelonken