Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to framesorter class #484

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

michaelonken
Copy link
Member

OverlapUtil:

  • Use framesorter class instead of using homegrown sorting.
  • Remove the related (then) unused sorting functionality

FrameSorter class:

  • Remember frame positions in Result
  • Also remember frame positions in sorting result since it is usually
    accessed anyway and interesting for library users that otherwise call
    the underlying method on FGInterface for all frames again.
  • The DummySorter does not provide frame positions to keep it as simple
    as possible (i.e. keep it "zero" cost).
  • Allow 2^32-1 frames as permitted in in DICOM (i.e. use Uint32 instead
    of Uint16) for frame number index.
  • Changed precision from Float32 to Float64 where applicable.
  • Added some documentation and some other small changes.

In order to make the class more generic, also handle more than 65535
frames (Number of Frames can be 2^32-1 max).
Also remember frame positions in sorting result since it is usually
accessed anyway and interesting for library users that otherwise call
the underlying method on FGInterface for all frames again.

The DummySorter does not provide frame positions to keep it as simple
as possible (i.e. keep  it "zero" cost).

Allow 2^32-1 frames as permitted in in DICOM (i.e. use Uint32 instead
of  Uint16) for frame number index.

Changed precision from Float32 to Float64 where applicable.

Added some documentation.
@fedorov fedorov merged commit c9738ca into QIICR:master Dec 6, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants