Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows block detection and automatic fix #1495

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

KamilDev
Copy link
Contributor

@KamilDev KamilDev commented Dec 7, 2024

Features

  • Automatically fixes the very common issue of Windows blocking the portable version zip from working.
  • If the automatic fix fails, gives the user clear instructions on how to fix the issue, instead of silently exiting.
  • Handle plugins that fail to load, allowing QuickLook to continue running without them.

How to test

  1. Build this PR version to get portable version.
  2. Upload the .zip to my simple web app File Download Simulator (source) to simulate downloading from online (just creates local blob URL and triggers the download).
  3. Right click on downloaded zip file -> Properties. You should see it now contains "Unblock" option. Don't do anything.
  4. Extract the zip using default Windows zip tool (using a tool like 7-zip may fix the block automatically).
  5. When running QuickLook.exe, you should get the following message box:

image

The application should restart and work as normal.
If it fails to automatically unblock, it will show the following message:

Screenshot 2024-12-07 135034

After following the instructions, and launching QuickLook.exe from the unblocked folder, it should work as normal.

@KamilDev KamilDev changed the title Implement Windows block detection Implement Windows block detection and automatic fix Dec 7, 2024
@emako
Copy link
Member

emako commented Dec 7, 2024

This works for #1

@emako emako merged commit 92778e6 into QL-Win:master Dec 7, 2024
1 of 2 checks passed
@KamilDev KamilDev deleted the feature/detect-windows-block branch December 8, 2024 03:50
@emako
Copy link
Member

emako commented Dec 23, 2024

Note: Transferring

Use UnblockZoneIdentifier as an alternative to PowerShell in subsequent steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants