Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Server specific commands registered when in client mode #902

Closed
dsvensson opened this issue Mar 2, 2024 · 2 comments
Closed

BUG: Server specific commands registered when in client mode #902

dsvensson opened this issue Mar 2, 2024 · 2 comments

Comments

@dsvensson
Copy link
Collaborator

dsvensson commented Mar 2, 2024

SV_InitOperatorCommands registers all sorts of fun stuff that a random server may invoke via stufftext. This set of commands should likely only be registered when starting a local ezquake server, and some of them should perhaps be completely removed.

@osm
Copy link
Contributor

osm commented Mar 2, 2024

Make sure you aren't using the -enablelocalcommand command, otherwise a malicious server can execute anything on the client computer:

https://github.com/QW-Group/ezquake-source/blob/master/src/sv_ccmds.c#L1856-L1857
https://github.com/QW-Group/ezquake-source/blob/master/src/sv_ccmds.c#L752

osm added a commit to osm/ezquake-source that referenced this issue Mar 2, 2024
A server can execute commands on the client via stufftext. Therefore, a
malicious server can perform evil operations. To limit the attack
vector, the following commands have been removed:

- chmod
- localcommand
- ls
- nslookup
- rm
- rmdir

This addresses issue QW-Group#902
osm added a commit to osm/ezquake-source that referenced this issue Mar 3, 2024
A server can execute commands on the client via stufftext. Therefore, a
malicious server can perform evil operations. To limit the attack
vector, the following commands have been removed:

- chmod
- localcommand
- ls
- nslookup
- rcon
- rm
- rmdir

This addresses issue QW-Group#902
@tcsabina
Copy link
Collaborator

tcsabina commented Mar 5, 2024

Fixed with #903

@tcsabina tcsabina closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants