RENDERER: Add support for skywind. #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvensson
force-pushed
the
skywind
branch
2 times, most recently
from
6d990d4 to
621f05a
Compare
Feature available in the SP community. Ported mostly verbatim from the IronWail engine. Partial cubemap alpha which gets blended with itself to create the illusion of a moving sky. Quite hypnotizing. To simplify tuning of the skybox the following commands are included in the port: * /skywind * /skywind_save * /skywind_load * /skywind_lookdir * /skywind_rotate If a config file named $skyboxname_wind.cfg in the same directory as the skybox is found, it's automatically loaded and configures the sky. Implemented for both modern and classic renderers.
dsvensson
commented
Dec 27, 2024
| return true; | ||
| } | ||
|
|
||
| void R_SkyRegisterCvars(void) |
There was a problem hiding this comment.
bad name, no cvars in sight
dsvensson
commented
Dec 27, 2024
| @@ -208,7 +232,7 @@ static qbool Sky_LoadSkyboxTextures(const char* skyname) | |||
| fixed_size = size; | |||
|
|
|||
| if (i == 0) { | |||
| skybox_cubeMap = R_CreateCubeMap("***skybox***", size, size, TEX_NOCOMPRESS | TEX_MIPMAP | TEX_NOSCALE); | |||
| skybox_cubeMap = R_CreateCubeMap("***skybox***", size, size, TEX_NOCOMPRESS | TEX_MIPMAP | TEX_NOSCALE | TEX_ALPHA); | |||
There was a problem hiding this comment.
This is mostly the only impact of this feature. Skyboxes will be 4bpp instead of 3bpp going forward. Uses a bit more GPU memory, but people who care about GPU memory likely disable skyboxes and are thus not affected by this, and it's not like it's a huge difference. However, making it optional would be less intuitive as it's not known if there's a skywind config available or not at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature available in the SP community. Ported mostly verbatim from the IronWail engine. Partial cubemap alpha which gets blended with itself to create the illusion of a moving sky. Quite hypnotizing.
To simplify tuning of the skybox the following commands are included in the port:
If a config file named $skyboxname_wind.cfg in the same directory as the skybox is found, it's automatically loaded and configures the sky.
Implemented for both modern and classic renderers.