Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to toggle klist/tracklist #382

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

osm
Copy link
Contributor

@osm osm commented Jan 4, 2025

No description provided.

@suddendeathTV
Copy link

Making it toggleable is great, but make sure to keep default at on.

Reason for that is that for any game that matters, nospecs will be in use regardless and klist does nothing. nospecs is extremely important in tournament games due to ghosting, so it'll always be active.

For fun games and mixes, klist should not automatically be disabled for no reason as some people think it's a cool feature.

@osm
Copy link
Contributor Author

osm commented Jan 5, 2025

Yes, the default setting is still to allow it; it needs to be explicitly disabled by running toggleklist

@tcsabina
Copy link
Collaborator

Hi Slime,
What is this PR about? There is the /klist command that shows the players, the specs, and who the specs spectate.

What will this PR add?

@osm
Copy link
Contributor Author

osm commented Jan 12, 2025

Hi,

It's to prevent players from gaining info that klist can provide them. For example, if the spectators are using autotrack, you can keep track of who in the enemy team that have quad or who has weapon/armor etc.

@tcsabina tcsabina merged commit 2e22f1b into QW-Group:master Jan 12, 2025
9 of 10 checks passed
@tcsabina
Copy link
Collaborator

Thanks, slime!

@tcsabina
Copy link
Collaborator

Would it be not confusing that we have 2 commands for the same function?
toggletracklist and toggleklist

@osm
Copy link
Contributor Author

osm commented Jan 12, 2025

Hmm yeah maybe, I thought they were basically the same command so I thought it would be ok to controll them with the same toggle, would you like me to add a separate toggle for tracklist?

@osm osm deleted the toggleable-klist branch January 12, 2025 11:40
@osm
Copy link
Contributor Author

osm commented Jan 12, 2025

Separate toggle for tracklist here #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants