Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build for downstream projects as well. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsvensson
Copy link
Collaborator

Uploads binaries as build artifacts rather than to the snapshots server.

Uploads binaries as build artifacts rather than to the snapshots server.
@tcsabina
Copy link
Collaborator

tcsabina commented Jun 3, 2022

Hey @dsvensson

I am probably not going to merge this...

All of the other repos within the QW-Group using more or less the same workflow. So if we change this, we might change it for the others as well, to have a consistent setup. Doable, but some work ;).

On the other hand, I don't fully get the idea of why would you need artifact creation on forks?
When you busy with development, you will build the project anyhow, as you need to test and verify your changes. And only if the change is good, you push.
So I see no point in having an artifact being created, as you don't use it for anything.

Of course, my way of working might be different, compared to anyone else. So before closing this without merge, I give you the possibility to convince me ;).
I will also draw the attention of this PR of other developers in the team, to see what do they think.

Regards,
Toma

@dsvensson
Copy link
Collaborator Author

dsvensson commented Jun 3, 2022

What drives me is sharing binaries before merge, partly for myself as I play under Windows, and develop under Linux. I can add PRs to the rest of the repos as well if you like. Also nice having cross platform build running before PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants