Port to PCRE2 (fixes #40) #152
Open
+87
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch was provided by Yavor Doganov <yavor@gnu.org> as seen in https://bugs.debian.org/1050187
|
Check CI for stuff left to fix. |
|
I've fixed the github pipeline for Linux, but I don't understand how Windows builds it. The build environment installs the correct pcre2 headers, but it still can't be found? |
|
See src/pcre. so just bump that and comment out system wide pcre detection from cmake config and hammer until it works, and once Linux works with that I expect windows to do so as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch is by Yavor Doganov yavor@gnu.org as seen in https://bugs.debian.org/1050187 (git author is set to attribute this properly).
Second patch by me cleans up a few bits.