Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 337: Remove compact() operation #374

Merged
merged 10 commits into from
Aug 2, 2024

Conversation

osopardo1
Copy link
Member

@osopardo1 osopardo1 commented Aug 1, 2024

Description

Changes #337

Type of change

Describe the change you're making: how it affects the API, user experience...

New feature.

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add logging to the code following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)

No tests are added. Those involving the compact() operation are removed.

@Jiaweihu08
Copy link
Member

We should also rename DataWriter.compact to DataWriter.optimize.

@Jiaweihu08
Copy link
Member

Also, simplify the QbeastTable.optimize methods, as there are a few combinations of input arguments with default empty options.

@osopardo1
Copy link
Member Author

Also, simplify the QbeastTable.optimize methods, as there are a few combinations of input arguments with default empty options.

working on it

@osopardo1 osopardo1 marked this pull request as ready for review August 2, 2024 05:05
@Jiaweihu08 Jiaweihu08 merged commit 330879f into Qbeast-io:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants