Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 380: Update html labels #381

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

jorgeMarin1
Copy link
Contributor

@jorgeMarin1 jorgeMarin1 commented Aug 2, 2024

Description

Fixes #380 . The MDX compiler complained of a html tag on the CONTRIBUTING.md file so I had to do this change:

"3. The title of the PR should follow the schema: Issue <issue-number>:<PR-title> "

Was changed to:

"3. The title of the PR should follow the schema: Issue &lt;issue-number&gt;: &lt;PR-title&gt;"

This way the compiler won't complain about nothing and the text will look like this (the issue number and the PR title text wasn't originally showing):

Screenshot 2024-08-02 at 17 27 59

Type of change

Documentation update.

Checklist:

Here is the list of things you should do before submitting this pull request:

  • Change the documentation.
  • Your branch is updated to the main branch (dependent changes have been merged).

@jorgeMarin1 jorgeMarin1 self-assigned this Aug 2, 2024
@jorgeMarin1 jorgeMarin1 added the type: documentation Improvements or additions to documentation label Aug 2, 2024
@jorgeMarin1 jorgeMarin1 requested review from cdelfosse and removed request for osopardo1 August 5, 2024 07:52
@jorgeMarin1 jorgeMarin1 changed the title Issue 380: Fix html tags on CONTRIBUTING.md Issue 380: Need to change html labels Aug 5, 2024
Copy link
Contributor

@cdelfosse cdelfosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jiaweihu08 Jiaweihu08 changed the title Issue 380: Need to change html labels Issue 380: Update html labels Aug 5, 2024
@Jiaweihu08 Jiaweihu08 merged commit 629e07d into Qbeast-io:main Aug 5, 2024
1 check passed
@jorgeMarin1 jorgeMarin1 deleted the update-contributing branch August 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to change html labels
3 participants